Skip to content

Conversation

@mlykotom
Copy link
Contributor

@mlykotom mlykotom commented Apr 15, 2024

Ading the plugins to the root level build.gradle without applying them directly. This is because some plugins might have different versions. For example, Baseline Profile Gradle Plugin had a dependency on AGP x, without specifying it here, Gradle would pick some dependency (which one? 🤔 ) and a conflict would be raised.

@mlykotom mlykotom requested a review from a team as a code owner April 15, 2024 10:10
@mlykotom mlykotom requested a review from IanGClifton April 15, 2024 10:10
# Conflicts:
#	Jetcaster/build.gradle.kts
@mlykotom mlykotom requested a review from arriolac April 19, 2024 07:50
@bentrengrove
Copy link
Member

Also important for #1354

@bentrengrove bentrengrove merged commit 25cde73 into main Apr 21, 2024
@bentrengrove bentrengrove deleted the tm/fix-plugins branch April 21, 2024 22:37
Copy link

@ThRiLKiLKuLt ThRiLKiLKuLt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should've went to college

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants